microsoft / microsoft/BotFramework-WebChat
Code: Expose `core/definitions/speakingActivity` for use in `BasicTranscript.js`
Open
Nobody has claimed this yet.
backlog
feature-request
p2
- Dominant language
- HTML
- Stars
- 1.8k
- Forks
- 1.6k
- Avg merge
- 22h 58m
- Merged PRs (30d)
- 2
Description
Feature Request
In BasicTranscript.js, we have this to-do:
// TODO: [P2] We should use core/definitions/speakingActivity for this predicate instead
shouldSpeak: activity.channelData && activity.channelData.speak
Today, we don't expose any definitions/selectors from core package.
Two ways:
- We expose and reuse it here
- We are moving speak-related stuff out from
core, so we might not need to take it
[Enhancement]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with BasicTranscript.js and the core/definitions/speakingActivity reference in the TODO. Check how definitions are currently exposed from the core package and review the existing speak-related code before choosing between exposing the definition and moving that functionality. Done means the selected approach lets BasicTranscript.js use the shared speaking-activity predicate without leaving the TODO unresolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, web-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100