microsoft / microsoft/BotFramework-WebChat
[Tracking] DLS: Stop renewing token if the connection has ended
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 1.8k
- Forks
- 1.6k
- Avg merge
- 22h 58m
- Merged PRs (30d)
- 2
Description
If you would want to prioritize this feature work, please vote and optionally, provide a user story.
Feature Request
Related to DLSpeech, /packages/directlinespeech/src/createAdapters.js line 122. If the dev passed an token, we will renew it every 2 minutes.
Today, we don't have a way to detect if the connection is dropped and renewal should be stopped.
We should ask the Cognitive Services team for an event (e.g. authorization failed) and implement the stopping mechanism.
[Enhancement]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/directlinespeech/src/createAdapters.js around line 122 and trace how the token is renewed. Confirm with the Cognitive Services team which event indicates that the connection has ended, then implement and verify that renewal stops after that event while continuing for an active connection.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure, javascript
- Domain
- api, authentication
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100