microsoft / microsoft/BotFramework-WebChat
Show a warning when using styleSet because of potential DOM tree change
Open
Nobody has claimed this yet.
backlog
feature-request
p2
- Dominant language
- HTML
- Stars
- 1.8k
- Forks
- 1.6k
- Avg merge
- 22h 58m
- Merged PRs (30d)
- 2
Description
Feature Request
We should consider adding a warning to dev build if developers are using styleSet to customize. This is because our DOM tree is inherently unstable. E.g. accessibility fixes would requires us to change it drastically.
[Enhancement]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating how styleSet customization is handled in the development build and where warnings are emitted. Review the DOM-tree stability and accessibility concern described in the issue; done should mean developers using styleSet receive an appropriate development warning without affecting production behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html
- Domain
- frontend, web-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100