microsoft / microsoft/BotFramework-WebChat
`core`: consider exporting our selectors from
Open
Nobody has claimed this yet.
backlog
feature-request
- Dominant language
- HTML
- Stars
- 1.8k
- Forks
- 1.6k
- Avg merge
- 22h 58m
- Merged PRs (30d)
- 2
Description
In BasicTranscript.js, we did not use core's selector for selecting speaking activity. We should consider exporting those selectors.
// TODO: [P2] We should use core/definitions/speakingActivity for this predicate instead
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the selector usage in BasicTranscript.js and the speaking-activity predicate in core/definitions/speakingActivity. Determine which selectors should be exported and how BasicTranscript.js should use them; done means the relevant core selectors are exported and the local selection no longer duplicates them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100