microsoft / microsoft/BotFramework-WebChat

Rename `bubbleBorderWidth` to `bubbleFromBotBorderWidth`

Open
#2,489 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backlog feature-request front-burner
Dominant language
HTML
Stars
1.8k
Forks
1.6k
Avg merge
22h 58m
Merged PRs (30d)
2

Description

Feature Request

Rename the followings:

  • bubbleBackground to bubbleFromBotBackground
  • bubbleBorderColor to bubbleFromBotBorderColor
  • bubbleBorderRadius to bubbleFromBotBorderRadius
  • bubbleBorderStyle to bubbleFromBotBorderStyle
  • bubbleBorderWidth to bubbleFromBotBorderWidth
  • bubbleNubOffset to bubbleFromBotNubOffset
  • bubbleNubSize to bubbleFromBotNubSize
  • bubbleTextColor to bubbleFromBotTextColor

Optionally, the user can specify bubbleNubSize, and it will propagate to both bubbleFromBotNubSize and bubbleFromUserNubSize. This also applies to other styles in the above set.

Additional context

Related to bubble nub work, #2137 and #2487.

[Enhancement]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the definitions and usages of the listed bubble style properties, then compare the related bubble nub work in issues #2137 and #2487. Done means the eight bot-facing properties use the requested names and the optional shorthand propagates to both bot and user styles as described.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.