microsoft / microsoft/BotFramework-DirectLineJS
Code: DirectLineJS should empty out contentUrl if it is a placeholder
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 199
- Forks
- 133
- PR merge metrics
- No merged PRs in 30d
Description
Feature Request
In core/src/reducers/activities.js, we have some code to empty out contentUrl if the attachment should not be downloadable. This code should be moved to DirectLineJS.
// TODO: [P2] This "contentURL" removal code should be moved to DirectLineJS adapter.
[Enhancement]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in core/src/reducers/activities.js and inspect the TODO describing the contentUrl removal. Trace the DirectLineJS adapter path to determine where this behavior belongs; done means the placeholder contentUrl handling is performed there rather than in the reducer.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- api
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100