microsoft / microsoft/BotFramework-DirectLineJS
IE11 compatibility: `Array.prototype.find` is not supported
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 199
- Forks
- 133
- PR merge metrics
- No merged PRs in 30d
Description
Array.prototype.find is not supported in IE11, and this is the only functions that is blocking for IE11.
I think we should consider either:
- Polyfill
Array.prototype.findin the primary buildimport 'core-js/modules/es6.array.find';
- Remove the use of
Array.prototype.find - Polyfill
Array.prototype.findin a separate ES5 build- Since this is the only function that is blocking for IE11, it won't increase the build size significantly to justify for a separate build
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Start by locating the Array.prototype.find usages and the primary and ES5 build configuration, then check how the library is tested for IE11 compatibility. Done means choosing and implementing one of the listed compatibility approaches so this is no longer the remaining IE11 blocker.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- build-system, web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100