microsoft / microsoft/BitNet

codegen_tl1.py contains strange {{ and }}

Open
#61 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
40.3k
Forks
3.7k
PR merge metrics
No merged PRs in 30d

Description

I think there is a bug in utils/codegen_tl1.py regarding the usage of {.
In the code always {{ and }} is used, but i think this is confusing/unnessary.

e.g. https://github.com/microsoft/BitNet/blob/5e39e75325db395285c8f2d84b6cdd6fa49bc27b/utils/codegen_tl1.py#L29

the generated headerfile then also contains {{ and }} of course

if you confirm that this syntax is kind of strange and we should fix it I could create a PR if you like

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open utils/codegen_tl1.py at the referenced line and inspect how the doubled braces are used when generating the header file. Compare the generator syntax with the resulting header output; done means confirming whether the braces are intentional and documenting or correcting the behavior accordingly.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.