microsoft / microsoft/BitNet

There are some data type inconsistencies in the tbl impl functions.

Open
#161 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
40.3k
Forks
3.7k
PR merge metrics
No merged PRs in 30d

Description

When I built the source codes of BitNet.cpp using gcc, some data type inconsistencies error occured.
However, this error did not occur when I used clang. I investigated the root cause of this problem.
I found that there are some data type inconsistence in the tbl impl functions.
The followin codes contain some data type inconsisitencies problem.

https://github.com/microsoft/BitNet/blob/caf17ec438808bcf9b3da012216c8624a29b8cdc/utils/codegen_tl1.py#L204-L207

https://github.com/microsoft/BitNet/blob/caf17ec438808bcf9b3da012216c8624a29b8cdc/utils/codegen_tl1.py#L235

https://github.com/microsoft/BitNet/blob/caf17ec438808bcf9b3da012216c8624a29b8cdc/utils/codegen_tl1.py#L252

We should add some data type reinterpreting cast processes in the codes.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with utils/codegen_tl1.py at lines 204-207, 235, and 252, then inspect the generated tbl implementation code and reproduce the reported gcc build error. Compare the affected types with the clang build and confirm the generated code handles them consistently. Done means the relevant BitNet.cpp source builds successfully with gcc without the reported type errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
machine-learning
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.