[Bug]: Undo Shipment of Drop Shipment generates Positive = false entries causing wrong inventory valuation
Nobody has claimed this yet.
- Dominant language
- AL
- Stars
- 683
- Forks
- 459
- Avg merge
- 3d 26m
- Merged PRs (30d)
- 633
Description
Describe the issue
When a drop shipment PO is received, the corresponding SO is also shipped.
if the customer decides to undo shipment on that sales order, the generated item ledger entries will generate Sales entries with positive quantities and Positive is set to false. This causes wrong output on the inventory valuation report.
Expected behavior
The generated item ledger entry of undo shipment should have Positive = true
Steps to reproduce
- Create SO with drop shipment items
- Create PO for the drop shipment SO
- Receive Purchase Order which will also ship the corresponding drop shipment
- Go to the Posted Sales Shipment Generated
- Undo Sales Shipment
- The Sales Shipment will be undone along with Purchase Receipt as well.
- Two item ledger entries are generated
- Both Positive = false (One for the purchase receipt reversal which is correct, and another for the sales shipment reversal which is incorrect and has to be = true).
Additional context
No response
I will provide a fix for a bug
- I will provide a fix for a bug
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the drop shipment undo flow described in the issue and inspect the two generated item ledger entries, especially the sales shipment reversal and its Positive value. Done means the sales shipment reversal has Positive=true while the purchase receipt reversal remains false, and the inventory valuation report reflects the correction.
Written by the indexing model from the issue text.
Assessment
- Domain
- backend, databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100