Restore ObsoleteTag '28.0' on Activate Legacy Subcontracting action (suppress AS0072 via pragma)
Nobody has claimed this yet.
- Dominant language
- AL
- Stars
- 683
- Forks
- 459
- Avg merge
- 3d 26m
- Merged PRs (30d)
- 633
Description
On the IT Manufacturing Setup page (page 99000768 "Manufacturing Setup"), the "Activate Legacy Subcontracting" action currently sets ObsoleteTag = '29.0'.
This value was bumped from '28.0' to '29.0' in #8966 solely to satisfy the AppSourceCop rule AS0072 (ObsoleteTag must match obsoleteTagVersion = 29.0). The action logically belongs to the same '28.0' obsoletion wave as the sibling "Disable Legacy Subcontracting" and "Pre Check Disable Legacy Subcontracting" actions and the parent LegacySubcontracting group, which all carry ObsoleteTag = '28.0'.
Proposed change
Restore ObsoleteTag = '28.0' on the "Activate Legacy Subcontracting" action and suppress AS0072 locally with a pragma, consistent with the existing pattern used elsewhere in the codebase (e.g. src/Layers/GB/BaseApp/Purchases/Vendor/VendorTempl.Table.al):
#pragma warning disable AS0072
ObsoleteTag = '28.0';
#pragma warning restore AS0072
File
src/Layers/IT/BaseApp/Manufacturing/Setup/ManufacturingSetup.Page.al
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open src/Layers/IT/BaseApp/Manufacturing/Setup/ManufacturingSetup.Page.al and compare the Activate Legacy Subcontracting action with its sibling actions and the LegacySubcontracting group. Review the pragma pattern in src/Layers/GB/BaseApp/Purchases/Vendor/VendorTempl.Table.al; done means the action uses ObsoleteTag '28.0' while AS0072 is suppressed locally.
Written by the indexing model from the issue text.
Assessment
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 85/100