[Bug]: Issued/Reminder Line GetCurrencyCodeFromHeader()
Nobody has claimed this yet.
- Dominant language
- AL
- Stars
- 683
- Forks
- 459
- Avg merge
- 3d 26m
- Merged PRs (30d)
- 633
Description
Describe the issue
The function GetCurrencyCodeFromHeader in table 298 "Issued Reminder Line" and table 296 "Reminder Line" gets the Currency Code from the header.
But the statement in line 351 is never true, because the locale variable is always empty and it reads for every Amount field and line the header new.
https://github.com/microsoft/BusinessCentralApps/issues/1875
Expected behavior
Only read once the Header.
Steps to reproduce
Set a breakpoint at the line in the code and open a Issued Reminder or Reminder.
Additional context
The local variable should be deleted.
I will provide a fix for a bug
- I will provide a fix for a bug
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating GetCurrencyCodeFromHeader() in tables 298, Issued Reminder Line, and 296, Reminder Line, then inspect the code around line 351. Reproduce the issue with a breakpoint while opening an Issued Reminder or Reminder. Done means the header is read only once for the relevant Amount fields and the unused local variable is removed.
Written by the indexing model from the issue text.
Assessment
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100