microsoft / microsoft/BCApps

[Event Request] Codeunit 561 - IC Data Exchange API - Pass the temporary IC inbox headers by VAR in the OnBeforeBufferICInbox…HeaderInsert events

Open Beginner friendly
#11,058 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Approved event-request ext-ready-to-implement Team: Finance
Dominant language
AL
Stars
683
Forks
459
Avg merge
3d 26m
Merged PRs (30d)
633

Description

Why do you need this change?

An extension that adds a BLOB field to IC Inbox Sales Header / IC Inbox Purchase Header cannot get that value into Buffer IC Inbox … Header when IC documents are sent over the API connection.

TransferFields copies a BLOB only if it is loaded, and FindSet on a temporary record does not load it. CalcFields would but it only works through a var record.

Describe the request

Add var to the temporary source-record parameter in the two OnBefore…Insert events of codeunit 561. Subscribers can then call CalcFields and write the result into the buffer record, which is already var.

Both events are in the same object and are the symmetric pair of one pattern, so they are submitted together.

EventRequest

[IntegrationEvent(false, false)]
local procedure OnPostICSalesHeaderToICPartnerInboxOnBeforeBufferICInboxSalesHeaderInsert(var BufferICInboxSalesHeader: Record "Buffer IC Inbox Sales Header"; var TempICPartnerICInboxSalesHeader: Record "IC Inbox Sales Header" temporary; ICPartner: Record "IC Partner"; RegisteredPartner: Record "IC Partner" temporary)
begin
end;

EventRequest

[IntegrationEvent(false, false)]
local procedure OnPostICPurchaseHeaderToICPartnerInboxOnBeforeBufferICInboxPurchaseHeaderInsert(var BufferICInboxPurchaseHeader: Record "Buffer IC Inbox Purch Header"; var TempICPartnerICInboxPurchaseHeader: Record "IC Inbox Purchase Header" temporary; ICPartner: Record "IC Partner"; RegisteredPartner: Record "IC Partner" temporary)
begin
end;
Provide an implementation (optional)
  • I will provide the implementation for this extensibility request

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate codeunit 561 and find the OnBeforeBufferICInboxSalesHeaderInsert and OnBeforeBufferICInboxPurchaseHeaderInsert events shown in the issue. Update the temporary source-record parameters to use var in both signatures, then verify the object compiles and that subscribers can access the temporary records for CalcFields before writing to the buffer records.

Written by the indexing model from the issue text.

Assessment

Domain
api, backend-api-design
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.