microsoft / microsoft/BCApps

[Extensibility Request] Add event "OnCustUnrealizedVATOnBeforeGetUnrealizedVATPart" in Codeunit 12 "Gen. Jnl.-Post Line"

Open Beginner friendly
#10,766 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

missing-info Team: Finance
Dominant language
AL
Stars
683
Forks
459
Avg merge
3d 26m
Merged PRs (30d)
633

Description

Why do you need this change?

In our Business Central solution for the construction industry, we have to process sales and purchase progress invoices with deductions and retentions using Unrealized VAT. When posting the payment applications to these invoices it is necessary to consider the retentions and therefore modify the VAT Part. We are only able to implement this properly on the Purchase side while on the Sales side it is not possible because of a missing event.

Describe the request

In codeunit 12 "Gen. Jnl.-Post Line" the both procedures

  • internal procedure CustUnrealizedVAT(...)
  • internal procedure VendUnrealizedVAT(...)

are posting the unrealized VAT Entry.

In both procedures the VATPart is calculated. It can be handled and modified by the event publisher OnVendUnrealizedVATOnBeforeGetUnrealizedVATPart(...) in VendUnrealizedVAT(...) only in the Vendor but not in the Customer version CustUnrealizedVAT(...) of the procedure. The corresponding event is missing there.

Our request:

Provide an corresponding event OnCustUnrealizedVATOnBeforeGetUnrealizedVATPart(...) with the same parameters (incl. IsHandled) like the named vendor version in the procedure CustUnrealizedVAT(...)

Provide an implementation (optional)
  • I will provide the implementation for this extensibility request

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in codeunit 12 "Gen. Jnl.-Post Line" and inspect the CustUnrealizedVAT and VendUnrealizedVAT procedures. Compare the existing OnVendUnrealizedVATOnBeforeGetUnrealizedVATPart publisher and its parameters with the customer-side VATPart calculation. Done means the corresponding customer event exists with matching parameters, including IsHandled, and is available from CustUnrealizedVAT.

Written by the indexing model from the issue text.

Assessment

Domain
backend-api-design
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
76/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.