[Bug]: [W1][xmlport][37200][Sales Cr.Memo - PEPPOL30] is not valid by XSD scheme
Nobody has claimed this yet.
- Dominant language
- AL
- Stars
- 683
- Forks
- 459
- Avg merge
- 3d 26m
- Merged PRs (30d)
- 633
Description
Describe the issue
XMLport for exporting credit memos to the Peppol BIS3 XML format was probably created as a copy of the invoice export, because it has the same structure of elements. But the XML file generated by this XMLport is not valid against Peppol UBL CreditNote scheme.
The XML element TaxPointDate is misplaced and should be moved rigth after the IssueDate element.
In the standard implementation of the providers, TaxPointDate value is empty and therefore it is not exported to the XML file and, therefore, the XML file without TaxPointDate is valid. But when the implementation of interface "PEPPOL Document Info Provider" is overridden and TaxPointDate has a value, the validation fails.
Expected behavior
The XML element TaxPointDate should be placed according to the XSD scheme, or as there is a definition on https://docs.peppol.eu/poacc/billing/3.0/syntax/ubl-creditnote/tree/.
Steps to reproduce
A new implementation of the interface is needed and there should be variable TaxPointDate filled.
Additional context
No response
I will provide a fix for a bug
- I will provide a fix for a bug
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the PEPPOL BIS3 XMLport that exports credit memos and inspect the element order around IssueDate and TaxPointDate. Move TaxPointDate to the position required by the UBL CreditNote XSD, then validate an export with a populated TaxPointDate against the Peppol scheme.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- xml
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100