microsoft / microsoft/AzureTRE

[UI] uiSchema params for overview property are overwritten by ui code

Open
#4,861 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
235
Forks
192
Avg merge
1d 23h
Merged PRs (30d)
13

Description

Describe the bug
in ui/app/src/components/shared/create-update-resource/ResourceForm.tsx the uiSchema is overwritten for the overview field, meaning other custom uiSchema cannot be set for it.

  const uiSchema = (template && template.uiSchema) || {};
  uiSchema.overview = {
 "ui:widget": "textarea",
}
``

**Steps to reproduce**
Setting the below has no effect because the ui overwrites it with `"ui:widget": "textarea"` 

"uiSchema": {
"overview": {
"ui:emptyValue": ""
}

see https://github.com/microsoft/AzureTRE/issues/4826#issuecomment-3840891730
**Azure TRE release version (e.g. v0.14.0 or main):**
main

**Deployed Azure TRE components - click the (i) in the UI:**
latest

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open ui/app/src/components/shared/create-update-resource/ResourceForm.tsx and inspect how the overview uiSchema is assigned. Reproduce the issue with the provided ui:emptyValue example, then verify that custom overview settings are preserved while the overview field still has its intended widget behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.