microsoft / microsoft/AzureTRE
Alteration to Airlock Approval/Rejection final form submission.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 235
- Forks
- 192
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 13
Description
When rejecting an Airlock Request the form on which you make the final Approval or Rejection features a dialog with reject and approve in the bottom right hand corner. In UI design (such as this github issue form) the rightmost green button is typically "Submit" (or "Create").
As a result being conditioned to submit forms with the bottom right button, the risk of adding a comment for Rejection and the submitting it with an Approval feels like a risk.
May I please suggest either:
- Completely break free from this UI design. Centre the Reject and Approve and make them look unlike buttons seen elsewhere.
or - Have the comment be saved conventionally and the option of approval or denial be on a subsequent step where the only consideration is "Do you wish to approve or reject this airlock request?"
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. First clarify which proposed UI direction is intended, then locate the Airlock approval/rejection form and its submission flow; done means the selected interaction clearly separates approval from rejection and avoids accidental approval when adding a rejection comment.
Written by the indexing model from the issue text.
Assessment
- Domain
- design, frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100