microsoft / microsoft/AzureTRE

Create tests to check terraform files

Open
#4,737 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

e2e-tests
Dominant language
Python
Stars
235
Forks
192
Avg merge
1d 23h
Merged PRs (30d)
13

Description

Is your feature request related to a problem? Please describe.
Related to #4735
There should be tests to ensure variables that are passwords or secrets have sensitive = true
So they are not leaked to users. I am sure there will be many other tests that may be useful linting etc

Describe the solution you'd like
Implement tests to cover the terraform code

Describe alternatives you've considered
Testing myself locally

Additional context
See also #4736

Tests that could be added
passwords or secrets have sensitive = true #4735
depends_on referencing itself #4741
formatting / linting

Tools that could be helpful for this
This could use tflint with custom rules
checkov security scans
https://github.com/bridgecrewio/checkov

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the repository's Terraform code and the related issues #4735, #4736, and #4741. Compare tflint custom rules and Checkov for the proposed checks, including sensitive password or secret variables and self-referencing depends_on values. Done means automated tests or scans cover the agreed Terraform rules.

Written by the indexing model from the issue text.

Assessment

Tech stack
terraform
Domain
infrastructure, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.