microsoft / microsoft/AzureTRE

Porter is expanding string parameters that look like scientific notation when passing to terraform

Open
#4,273 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
235
Forks
192
Avg merge
1d 23h
Merged PRs (30d)
13

Description

In a custom template, we are passing the four character short resource ID into a template and using it within terraform.

Occassionally this resembles a number in scientific notation, e.g. 51e5.

When this occurs, porter is expanding the scientific notation, and passing 510000000 into terraform, which causes our template to fail.

Not strictly a TRE issue as the expansion appears to be happening within the terraform mixin, but logging for visibility.

Logged here: https://github.com/getporter/terraform-mixin/issues/124

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked terraform-mixin issue 124 and reproduce the problem using a short resource ID such as 51e5 in a custom template. Check whether the value reaches Terraform as 510000000 rather than the original string; done means the issue's ownership and expected fix are clarified.

Written by the indexing model from the issue text.

Assessment

Tech stack
terraform
Domain
infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.