microsoft / microsoft/AzureTRE

Airlock notifier doesn't notify of rejected requests

Open
#4,094 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

story
Dominant language
Python
Stars
235
Forks
192
Avg merge
1d 23h
Merged PRs (30d)
13

Description

Describe the bug
The Airlock Notifier workflow notifies the workspace team that a request has been approved, but it doesn't notify them that a request has been rejected. So if the Airlock Manager rejects a request, they are left without any indication of that unless they happen to be polling the status page.

This is undesirable, the user should be notified of the rejection, and the reviewer's reason for rejecting the request should be included.

Steps to reproduce

  1. As a Workspace team member, create an airlock import or export request
  2. As an Airlock Manager, reject the request
  3. Wait for an email that never comes

Azure TRE release version (e.g. v0.14.0 or main):

Deployed Azure TRE components - click the (i) in the UI:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the Airlock Notifier workflow used after an import or export request is rejected, then compare it with the approval notification path. Confirm how the reviewer's rejection reason is stored or exposed. Done means workspace team members receive a rejection email that includes that reason, with the rejection scenario covered by an appropriate test.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.