microsoft / microsoft/AzureTRE
Airlock notifier doesn't notify of rejected requests
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 235
- Forks
- 192
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 13
Description
Describe the bug
The Airlock Notifier workflow notifies the workspace team that a request has been approved, but it doesn't notify them that a request has been rejected. So if the Airlock Manager rejects a request, they are left without any indication of that unless they happen to be polling the status page.
This is undesirable, the user should be notified of the rejection, and the reviewer's reason for rejecting the request should be included.
Steps to reproduce
- As a Workspace team member, create an airlock import or export request
- As an Airlock Manager, reject the request
- Wait for an email that never comes
Azure TRE release version (e.g. v0.14.0 or main):
Deployed Azure TRE components - click the (i) in the UI:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the Airlock Notifier workflow used after an import or export request is rejected, then compare it with the approval notification path. Confirm how the reviewer's rejection reason is stored or exposed. Done means workspace team members receive a rejection email that includes that reason, with the rejection scenario covered by an appropriate test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100