microsoft / microsoft/AzureTRE
Refactor environment scripts out of Github Actions
Open
Nobody has claimed this yet.
story
- Dominant language
- Python
- Stars
- 235
- Forks
- 192
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 13
Description
Description
As a TRE Developer
I want to configure computed environment variables inside the dev container / makefile
So that the CICD won't need to compute those values too.
This should be the proper fix for https://github.com/microsoft/AzureTRE/issues/3488
Acceptance criteria
-
TRE_URL,ARM_ENVIRONMENTare computed inside the devcontainer even when running on Github Actions. Specific steps on action.yml file are removed. - Files .github/scripts/construct_tre_url.sh, .github/scripts/convert_azure_env_to_arm_env.sh are removed from the deployment repo.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with .github/workflows/action.yml and the two scripts in .github/scripts/ to trace how TRE_URL and ARM_ENVIRONMENT are currently computed. Then inspect the devcontainer and Makefile entry points; done means those values are computed there during GitHub Actions and both listed scripts and their action steps are removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, shell
- Domain
- build-system, ci-cd
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100