microsoft / microsoft/AzureTRE

Simplify NSGs applied to workspace VNets by removing peer from virtual network tag

Open
#3,065 2 comments 0 reactions 1 assignee View on GitHub

@marrobi is already working on this.

Since Jan 30, 2023.

blocked feature
Dominant language
Python
Stars
235
Forks
192
Avg merge
1d 23h
Merged PRs (30d)
13

Description

At present the workspace to core vnet peer and core to workspace net peer has this setting set to Allow:
image

This makes the core VNet part of the VirtualNetwork tag used by network security groups. This means within NSGs we need to keep track of workspace address spaces, and if the VirtualNetwork is used inadvertently it also allows access to the core network.

As we have explicit allow and deny rules on the NSGs changing this setting to Block all traffic to the remote virtual network should have no adverse affect. However this should be verified.

Once disabled NSG configurations can revert to using the VirtualNetwork tag which leads to easier to read definitions and simplifies Terraform.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.