microsoft / microsoft/AzureTRE

If deploy two workspaces in parallel get VNet address space overlap

Open
#2,986 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
235
Forks
192
Avg merge
1d 23h
Merged PRs (30d)
13

Description

When running the e2e, the creation of workspace fails since the two workspaces are being created in the exact same time, and since we have an asynchronous cosmos client now, the two requests are happening simultaneously, hence getting the exact same vnet address space.
Added a temp fix on the tests to delay workspace creation by a random few seconds (random.uniform(1,9)).

Describe the bug
Failure sending request: StatusCode=400 -- Original Error: Code="VnetAddressSpaceOverlapsWithAlreadyPeeredVnet"

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the e2e tests that create workspaces and the asynchronous Cosmos client path involved in workspace creation. Reproduce the parallel creation failure and trace how VNet address spaces are selected. Done means concurrent workspace creation no longer produces overlapping VNet address spaces or the reported Azure error, without relying on the temporary random delay.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, python
Domain
cloud, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.