microsoft / microsoft/AzureTRE
AD settings on workspace creation page should adhere to AUTO_WORKSPACE_APP_REGISTRATION and AUTO_WORKSPACE_GROUP_CREATION
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 235
- Forks
- 192
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 13
Description
When deploying a workspace the user is prompted to choose authentication settings. As these are defined by AUTO_WORKSPACE_APP_REGISTRATION and AUTO_WORKSPACE_GROUP_CREATION they should not be user configurable as this can lead to mismatch with the app registration configuration and workspace deployment fails as per #3190
Notes:
At present this need this file https://github.com/microsoft/AzureTRE/blob/main/api_app/schemas/azuread.json to be edited. This means that the API app needs to be rebuilt. I suggest the values in this file are dynamically generated so they can be customised without rebuilding the API image.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.