microsoft / microsoft/AzureTRE
Standardise on variable names for auth
Open
Nobody has claimed this yet.
story
- Dominant language
- Python
- Stars
- 235
- Forks
- 192
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 13
Description
Description
As a TRE Administrator
I want to have standard names for the auth environment variables
So that we understand what these variables are used for
Acceptance criteria
- AAD_TENANT_ID becomes AAD_AUTH_TENANT_ID
- API_CLIENT_ID becomes AAD_AUTH_CLIENT_ID
Any more @marrobi ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for AAD_TENANT_ID and API_CLIENT_ID to identify every reference to the authentication environment variables. Rename the references to AAD_AUTH_TENANT_ID and AAD_AUTH_CLIENT_ID, then verify that the old names no longer remain and run the relevant project checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- authentication
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100