microsoft / microsoft/AzureStorageExplorer

Relax conditions for direct link commands

Open
#9,105 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

:gear: deep link :gear: sas
Dominant language
No language data
Stars
452
Forks
92
Avg merge
15h 20m
Merged PRs (30d)
3

Description

Now that we have support for SAS based direct links, we need to update conditions for when we show/enable direct-link related commands.


Current behavior

The "Copy Direct Link" command on blob container nodes (and the equivalent in the Blob Container editor) only appears when the container is reached through a signed-in subscription. With a SAS-attached container, the command is hidden -- even though Storage Explorer can now consume SAS-based direct links via the Sas Deep Link dialog.

The same gating is in place for other resource types that have a "Copy Direct Link" command (blobs, queues, tables, file shares, etc.) -- anywhere we gate on "signed-in only," we should reconsider now that SAS deep links work end to end.

Proposed behavior

When the user invokes "Copy Direct Link" on a node reached via SAS:

  • Generate a SAS-style direct link (same format the Sas Deep Link dialog consumes) instead of the subscription-scoped v2 link.
  • Show / enable the command on SAS-attached resources, not just signed-in ones.

Out of scope (commands should remain hidden):

  • Resources attached via account key or connection string -- no shareable token, so no link to produce.
  • "Secondary endpoint" views -- existing rule still applies.

Scope sweep needed

Audit every resource type that has a "Copy Direct Link" action and apply the same relaxation consistently:

  • Blob containers (tree node + container editor)
  • Individual blobs (blob editor)
  • Queues
  • Tables
  • File shares / directories / files
  • Anything else currently gated on sign-in

The behavior should be uniform -- a tester shouldn't have to remember "queues work with SAS but blob containers don't."

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Audit the existing "Copy Direct Link" actions across blob containers, blobs, queues, tables, file shares, directories, and files, starting with their current signed-in gating. Done means SAS-attached resources show or enable the command and produce the SAS-style link, while account-key, connection-string, and secondary-endpoint resources remain excluded.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure
Domain
cloud
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.