microsoft / microsoft/AzureStorageExplorer

Handle high contrast themes better when system is in high contrast

Open
#4,636 5 comments 0 reactions 1 assignee View on GitHub

@craxal is already working on this.

Since Jul 6, 2021.

:computer: windows :eye_speech_bubble: theming :gear: usability :grey_question: external
Dominant language
No language data
Stars
452
Forks
92
Avg merge
15h 20m
Merged PRs (30d)
3

Description

When system high contrast is turned on, Storage Explorer colors don't behave very well, even when the app's theme is set to High Contrast -Black or High Contrast - White. More specifically, borders for trees and tables are colored incorrectly.

image

The reason for this is because when system high contrast is turned on, the OS forces most colors into system colors (defined by the user). This means, no matter how we style certain elements, colors will always be forced to OS configured colors. This happens even if an element is styled with a hex value matching a system color. For example, even if the border color of the tree nodes is set to the correct cyan color, it will still be forced to white.

To better handle this situation, I propose the following:

  • When system high contrast is turned on, ignore the app theme setting and use a "special" theme that uses system colors.
  • Keep our current high contrast black/white themes as app theme choices for when system high contrast is turned off.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.