microsoft / microsoft/AzureStorageExplorer

It would be better to show a clear error when uploading files to one SAS (generated by access policy) attached file share without sufficient permissions

Open
#4,043 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

:beetle: azcopy error reporting :gear: attach :gear: azcopy :gear: sas :test_tube: testing
Dominant language
No language data
Stars
452
Forks
92
Avg merge
15h 20m
Merged PRs (30d)
3

Description

Storage Explorer Version: 1.17.0
Build Number: 20210202.9
Branch: main
Platform/OS: Windows 10/ CentOS 7.6.1810 (Core)/ MacOS Catalina
Architecture: ia32/x64
Regression From: Not a regression

Steps to Reproduce

  1. Expand one storage account -> File Shares.
  2. Create a file share -> Right click the file share.
  3. Click 'Manage Access Policies...' -> Add one access policy with permissions 'Read & List' and save it.
  4. Generate a SAS for the file share with the access policy.
  5. Attach the file share with the SAS -> Upload one file to the SAS attached file share.
  6. Check whether the error is clear.

Expected Experience

It would be better to show a clear error. Like 'Insufficient credentials'.

Actual Experience

Show the error 'UnexpectedCancel' in the failed activity log.
image
Error details:
{ "message": "\"UnexpectedCancel\"" }

Additional Context

  1. This issue also reproduces for Blob Containers.
  2. This issue also reproduces for Clone/ Copy & Paste actions.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failed upload with a SAS limited to Read and List permissions, then compare the failed activity log with the issue's reported "UnexpectedCancel" error. Trace the error handling for file-share and blob-container uploads, as well as Clone/Copy and Paste actions; done means insufficient permissions produce a clear user-facing error instead of "UnexpectedCancel".

Written by the indexing model from the issue text.

Assessment

Tech stack
azure
Domain
cloud
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.