microsoft / microsoft/AttackSurfaceAnalyzer
Add Arguments to Strings.Get arguments
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- C#
- Stars
- 3k
- Forks
- 294
- PR merge metrics
- No merged PRs in 30d
Description
When a Strings.Get call fails to find a string in the table it returns the original string that was called. This means that any data that might be slotted in later using a string.format is lost.
Solution: Rename the labels for strings to include the number of arguments they have as well.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Strings.Get implementation and the string-table label definitions. Trace a missing-string lookup with format arguments, then verify that the labels include the argument count and that later string.format data is preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- localization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100