microsoft / microsoft/ApplicationInsights-JS
Allow more characters in the user id
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 685
- Forks
- 261
- Avg merge
- 21h 33m
- Merged PRs (30d)
- 5
Description
**Is your feature request related to a problem? Please describe.**
I'm a bit puzzled as to why the authenticatedUserId does not accept a certain set of characters like spaces or ,;=|. Auth0 uses pipes by default in all "subjects" so to use app insights with auth0 you have to urlencode the user id. For other instrumentation libraries in other languages, the same restriction does not apply, which makes me wonder if it is actually necessary
**Describe the solution you'd like**
Allow a larger character set.
**Describe alternatives you've considered**
Escaping the characters when they appear in a user id.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the authenticatedUserId validation entry point and checking how its current character restrictions are enforced. Compare the behavior with the issue's Auth0 example, decide which additional characters are supported, and add tests showing accepted and rejected identifiers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100