microsoft / microsoft/Analysis-Services

BPA Rules : Provide format string for measures should work with Dynamic format expression

Open
#229 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
732
Forks
433
PR merge metrics
No merged PRs in 30d

Description

Hello,
since Dynamic format strings were presented for measures in PowerBI Desktop, I believe that BPA Rule [Formatting] Provide format string for measures should be updated by this way:
not IsHidden and not Table.IsHidden and string.IsNullOrWhitespace(FormatString) and string.IsNullOrWhitespace(FormatStringExpression)

Currently it validates only FormatString attribute which is empty when you are using dynamic format string in your measure. When you are using danymic format string then FormatStringExpression attribute is used.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the BPA rule named "Formatting: Provide format string for measures" and inspect how it checks FormatString. Update the rule to account for FormatStringExpression as described in the issue, then verify that measures with dynamic format expressions are not flagged while measures missing both values still are.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.