microsoft / microsoft/Analysis-Services
BPARules : Whole numbers should be formatted with thousands separators and no decimals is violated also for decimals
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 732
- Forks
- 433
- PR merge metrics
- No merged PRs in 30d
Description
Hello,
I suggest to update definition of rule Whole numbers should be formatted with thousands separators and no decimals. Currently this rule is violated also for decimal / double values. This is not correct, it should check only the presence of thousand separators for integers.
I would update the rule definition by following way:
DataType == DataType.int64
and
(
String.IsNullOrWhitespace(FormatString)
or
FormatString <> "#,0"
)
I did some testing on my test PowerBI dataset and it has been working fine. But I will appreciate any feedback from your side.
Regards,
Jiri
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Locate the BPARules definition for “Whole numbers should be formatted with thousands separators and no decimals” and inspect how DataType and FormatString are evaluated. Done means the rule checks only int64 values and no longer reports decimal or double values, while preserving the intended format validation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- databases, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100