microsoft / microsoft/Analysis-Services

Sonatype issues related to ALM Toolkit

Open
#123 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
732
Forks
433
PR merge metrics
No merged PRs in 30d

Description

Hi,
We wanted to use ALM Toolkit for source control of PowerBI datasets. However, due to some vulnerabilities, we are unable to. I've included the text below. Anything I can do to help make this clearer or easier to solve, please let me know!

Components:
Newtonsoft.Json 10.0.3
Newtonsoft.Json 12.0.1
Newtonsoft.Json 12.0.3
Newtonsoft/Json.NET Newtonsoft.Json.dll 12.0.3.23909

The Newtonsoft.Json package is vulnerable to a Denial of Service (DoS) attack. The JsonSerializerSettings.cs file and the constructor in the JsonReader class fails to enforce a sufficient maximum depth when serializing nested JSON objects. Consequently, serializing large numbers of nested JSON objects may cause the application to crash with a StackOverflowException. A remote attacker who can supply JSON data to be serialized by the application can exploit this vulnerability to cause a DoS condition or other unexpected behavior.

Components:
MSBuild.Extension.Pack 1.8.0

DotNetZip is vulnerable to arbitrary file write. By creating a zip archive with relative paths, an attacker can overwrite any files that the current process has access to. An attacker can use this to compromise a system by overwriting files such as the web.config which can affect either integrity and confidentiality, or at a bare minimum availability.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating how the ALM Toolkit includes Newtonsoft.Json and MSBuild.Extension.Pack, then review the reported JsonSerializerSettings.cs and JsonReader constructor concerns. Determine whether dependency versions can be updated or replaced without breaking PowerBI dataset source control; done means the reported vulnerable components are no longer present.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.