microsoft / microsoft/AdaptiveCards
FactSet spacing property in html host config doesn't work
Open
Nobody has claimed this yet.
Good First Issue
Platform-JavaScript
- Dominant language
- C#
- Stars
- 2k
- Forks
- 595
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 1
Description
The existing code in card_elements.ts is adding margin to element. However tr tag doesn't honor margin styles.
Suggestion fix would be using padding instead.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open card_elements.ts and trace how the FactSet spacing property is applied in the HTML host configuration. Verify the generated table row styling, then update the spacing behavior so the FactSet uses padding rather than margin on the tr element.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend, web-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100