microsoft / microsoft/AdaptiveCards

[Rendering] Font colors are hardcoded and some TextBlocks don't react to theme change

Open
#9,391 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Renderers Bug
Dominant language
C#
Stars
2k
Forks
595
Avg merge
1d 19h
Merged PRs (30d)
1

Description

Target Platforms

Other

SDK Version

2.2.4-beta

Application Name

Microsoft PowerToys

Problem Description

Coming from issue https://github.com/microsoft/PowerToys/issues/49435

Some text doesn't respond to theme change. I see that colors are hardcoded in https://github.com/microsoft/AdaptiveCards/blob/23b09872ec0f987ae427a69525d8f0fca256ab3f/source/dotnet/Library/AdaptiveCards/Rendering/ForegroundColorsConfig.cs
For WinUI 3, I recommend to check and support/use theme resources, and to check the refresh behavior regarding the app theme switching.

Screenshots

See linked issue

Card JSON
?
Sample Code Language

No response

Sample Code

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with source/dotnet/Library/AdaptiveCards/Rendering/ForegroundColorsConfig.cs and the linked issue #49435. Trace how WinUI 3 rendering obtains foreground colors and whether theme changes refresh existing TextBlocks. Done means rendered text responds correctly when the app theme switches, including the affected PowerToys case.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop-dev, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.