microsoft / microsoft/AdaptiveCards

[Adaptive Cards - Designer] - Ensures ARIA attributes are not prohibited for an element's role (.acd-peer[title="Double click to edit"][aria-label="TextBlock"]:nth-child(2))

Open
#9,033 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A11yAuto A11yCT A11yMissing_HCLReviewed A11yRT A11ySev3 A11yWCAG AdaptiveCards_Web Area-Accessibility Area-Renderers Bug HCL-AdaptiveCards-Web HCL-E+D MissingReviewedDeprecated Product-AC
Dominant language
C#
Stars
2k
Forks
595
Avg merge
1d 19h
Merged PRs (30d)
1

Description

Target Platforms

Other

SDK Version

1.6

Application Name

Adaptive Cards

Problem Description

Test Environment:
URL: https://adaptivecards.io/samples/ProductVideo.html
OS Version: 22H2(OS Build 25300.1000)
Browser Version: Edge Dev Version 111.0.1661.36 (Official build) dev (64-bit)
Tool: Accessibility Insight For Web

Repro Steps:

  1. Open the above URL on the Edge Dev browser.
  2. Press tab key and navigate to the designer tab and press enter key to activate it.
  3. Run the tool and observe the issue.

Actual Result:
ARIA attributes are prohibited for an element's role (.acd-peer[title="Double click to edit"][aria-label="TextBlock"]:nth-child(2))

Expected Result:
Ensures ARIA attributes are not prohibited for an element's role (.acd-peer[title="Double click to edit"][aria-label="TextBlock"]:nth-child(2))

Element path: .acd-peer[title="Double click to edit"][aria-label="TextBlock"]:nth-child(2)

Snippet:

How to fix:
Fix all of the following:
aria-label attribute cannot be used on a div with no valid role attribute.

User Impact:
It will impact the AT user if the ARIA attributes are prohibited for any controls on the screen.

WCAG Reference:
https://www.w3.org/WAI/WCAG21/Understanding/name-role-value

Have feedback to share on Bugs? please tag bug as “A11yRCA” and add your feedback in the comment section

Screenshots

Ensures ARIA attributes are not prohibited for an element's roles

Ensures ARIA attributes are not prohibited for an element's role

Card JSON
NA
Sample Code Language

No response

Sample Code

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the problem at https://adaptivecards.io/samples/ProductVideo.html by opening the Designer tab and running Accessibility Insights for Web. Start from the designer element matching .acd-peer[title="Double click to edit"][aria-label="TextBlock"]:nth-child(2); done means its aria-label is valid for its role and the accessibility check no longer reports a prohibited ARIA attribute.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.