microsoft / microsoft/AdaptiveCards
[Adaptive Cards - Designer] - Ensures ARIA attributes are not prohibited for an element's role (.acd-peer[title="Double click to edit"][aria-label="TextBlock"]:nth-child(2))
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2k
- Forks
- 595
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 1
Description
Target Platforms
Other
SDK Version
1.6
Application Name
Adaptive Cards
Problem Description
Test Environment:
URL: https://adaptivecards.io/samples/ProductVideo.html
OS Version: 22H2(OS Build 25300.1000)
Browser Version: Edge Dev Version 111.0.1661.36 (Official build) dev (64-bit)
Tool: Accessibility Insight For Web
Repro Steps:
- Open the above URL on the Edge Dev browser.
- Press tab key and navigate to the designer tab and press enter key to activate it.
- Run the tool and observe the issue.
Actual Result:
ARIA attributes are prohibited for an element's role (.acd-peer[title="Double click to edit"][aria-label="TextBlock"]:nth-child(2))
Expected Result:
Ensures ARIA attributes are not prohibited for an element's role (.acd-peer[title="Double click to edit"][aria-label="TextBlock"]:nth-child(2))
Element path: .acd-peer[title="Double click to edit"][aria-label="TextBlock"]:nth-child(2)
Snippet:
How to fix:
Fix all of the following:
aria-label attribute cannot be used on a div with no valid role attribute.
User Impact:
It will impact the AT user if the ARIA attributes are prohibited for any controls on the screen.
WCAG Reference:
https://www.w3.org/WAI/WCAG21/Understanding/name-role-value
Have feedback to share on Bugs? please tag bug as “A11yRCA” and add your feedback in the comment section
Screenshots
Card JSON
NA
Sample Code Language
No response
Sample Code
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the problem at https://adaptivecards.io/samples/ProductVideo.html by opening the Designer tab and running Accessibility Insights for Web. Start from the designer element matching .acd-peer[title="Double click to edit"][aria-label="TextBlock"]:nth-child(2); done means its aria-label is valid for its role and the accessibility check no longer reports a prohibited ARIA attribute.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100