microsoft / microsoft/AdaptiveCards

[Adaptive Cards - Restaurant Order.JSON] - Ensures every form element has a label (.ac-input.ac-multichoiceInput.ac-choiceSetInput-filtered)

Open
#9,020 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A11yAuto A11yCT A11yMissing_HCLReviewed A11ySev3 A11yWCAG Accessibility-WCP AdaptiveCards_Web Area-Accessibility Area-Renderers Bug HCL-AdaptiveCards-Web HCL-E+D MissingReviewedDeprecated Product-AC
Dominant language
C#
Stars
2k
Forks
595
Avg merge
1d 19h
Merged PRs (30d)
1

Description

Target Platforms

Other

SDK Version

1.6

Application Name

Adaptive Cards

Problem Description

Test Environment:
URL: https://adaptivecards.io/
OS Version: Dev (OS Build 27695.1000)
Browser Version: Version 130.0.2849.1 (Official build) dev (64-bit)
Tool: Accessibility Insight For Web

Repro steps:

  1. Open the above URL in the edge dev browser.
  2. Navigate to the 'Sample' option and press enter key to activate it.
  3. Press tab key and navigate to the 'Restaurant order' link and press enter key to activate it.
  4. Run the tool and observe the issue.

Actual Result:
Form field present under 'Malt & Vine order form' does not have a label.

Expected Result:
Ensures every form element has a label (.ac-input.ac-multichoiceInput.ac-choiceSetInput-filtered)

Element path:
#__ac-aa99fbc6-f4f6-4386-a239-70f1fe2b9a88 > .ac-input.ac-multichoiceInput.ac-choiceSetInput-filtered

Snippet:

How to fix:
Fix any of the following:
Form element does not have an implicit (wrapped)
Form element does not have an explicit
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute
Element has no placeholder attribute
Element's default semantics were not overridden with role="none" or role="presentation"

Note:
Same issue is repro on input. Time screen.

User Impact:
It will impact the screen reader user if the form field does not have proper label due to this user will not able to know about the form field.

WCAG Reference:
https://www.w3.org/WAI/WCAG21/Understanding/name-role-value.html

Have feedback to share on Bugs ? please tag bug as “A11yRCA” and add your feedback in the comment section

Screenshots

Ensures every form element has a label ( ac-input ac-multichoiceInput ac-choiceSetInput-filtered)

Ensure every form has a label

Image
Card JSON
NA
Sample Code Language

No response

Sample Code

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the adaptivecards.io Sample page, open the Restaurant order card, and inspect the input matching .ac-input.ac-multichoiceInput.ac-choiceSetInput-filtered. Use Accessibility Insight For Web to verify the form field's accessible name; done means the field has a valid label or equivalent accessible naming and the issue no longer reproduces.

Written by the indexing model from the issue text.

Assessment

Tech stack
html, javascript
Domain
accessibility, frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.