microsoft / microsoft/AdaptiveCards
[Rendering] Bug Title Here
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2k
- Forks
- 595
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 1
Description
Target Platforms
UWP
SDK Version
10.0.17763.0
Application Name
N/A
Problem Description
We need to check RootElement for nullptr here https://github.com/microsoft/AdaptiveCards/blob/4745cb65ae8d57529811f7a0ba13f04afbadcacc/source/uwp/SharedRenderer/lib/XamlBuilder.cpp#L58 to avoid various crashes (AV most common) if we failed to render rootelement.
Screenshots
No response
Card JSON
[]
Sample Code Language
No response
Sample Code
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open source/uwp/SharedRenderer/lib/XamlBuilder.cpp at the referenced line and inspect how RootElement is used after rendering. Verify the failure case represented by the empty card JSON, then ensure rendering does not continue when RootElement was not produced. Confirm the change prevents the reported access violations without affecting successful rendering.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100