microsoft / microsoft/AdaptiveCards
[Feature Request] Can we make 'Swiper' dependency optional?
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2k
- Forks
- 595
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 1
Description
Problem Statement
We are using this 'adaptivecards' package in our web app to render Adaptive Card payload, but we don't support mobile browser (we have native mobile apps for that). We find that the 'swiper' package, which 'adaptivecards' depends on, adds 139KB to our total bundle.
From my understanding, the 'swiper' package is not cross platform. It is meant only for mobile apps and mobile websites. As such, our web app is essentially bundling dead code.
Proposed solution
Is it possible to make 'swiper' an optional dependency so that we can exclude this library from our bundle? I see that it is being used by the Carousel.ts file via the require() statement. Can we change it to a dynamic import so that it doesn't fail if 'swiper' is not available?
Alternatives or Workarounds
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with Carousel.ts and the package dependency configuration; trace the current require() and how the web bundle includes swiper. Done means swiper can be absent without a load failure and consumers that need the Carousel still work, with the bundle impact verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- build-system, frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100