microsoft / microsoft/AdaptiveCards
[Feature Request] Feature Title Here
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2k
- Forks
- 595
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 1
Description
Problem Statement
I need to have custom functions with the same name, that do different things based on the template using them. Please give us the ability to add in our own Evaluation Context property. This should be a very small change.
Proposed solution
Please give us the ability to add Evaluation Context.
Add it to the parse value here, make the default value null.
https://github.com/microsoft/AdaptiveCards/blob/d05c6d8d60bae71e56c47208061a0c5aa6ca6fcb/source/dotnet/Library/AdaptiveCards.Templating/AdaptiveCardsTemplateVisitor.cs#L680
And here is that line in the other library.
https://github.com/microsoft/botbuilder-dotnet/blob/ed06db29062d26c0ffbaf1807e8728ba3eacc017/libraries/AdaptiveExpressions/Expression.cs#L147
Alternatives or Workarounds
I will make the functions have separate names. This is not how our library currently handles it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in source/dotnet/Library/AdaptiveCards.Templating/AdaptiveCardsTemplateVisitor.cs at the linked parse-value location, then compare the Evaluation Context handling in botbuilder-dotnet's Expression.cs. Done means the templating library accepts a caller-provided Evaluation Context while retaining null as the default.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100