microsoft / microsoft/AdaptiveCards

If the sample data is incorrect, it keeps using the previous data

Open
#8,842 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
2k
Forks
595
Avg merge
1d 19h
Merged PRs (30d)
1

Description

If you enter and edit sample data in the sample data editor and make an error in de JSON:

  • this is not clear there is an error in the sample data
  • the preview is still based on the 'old' data of the sample data editor

It took me quite a while before I figured out this was the cause of my template not to work. I would expect the preview to fail and show a message about an error in the sample data.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the problem in the sample data editor by entering invalid JSON and opening the preview. Compare the preview behavior with the requested failure message, and verify that the preview no longer uses the previous sample data.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.