microsoft / microsoft/AdaptiveCards
[Rendering][Xaml] Positive and Destructive Actions have incorrect button styling
Open
Nobody has claimed this yet.
Area-Renderers
Bug
- Dominant language
- C#
- Stars
- 2k
- Forks
- 595
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 1
Description
Target Platforms
Other
SDK Version
1.5
Application Name
Dev Home
Problem Description
Actions with style "default" have correct, rounded corner. Actions with Positive or Destructive styling have square corners.
Screenshots
Default:
Positive and Destructive:
Card JSON
{
"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
"type": "AdaptiveCard",
"version": "1.5",
"body": [
{
"type": "TextBlock",
"text": "Adaptive Card design session",
"size": "large",
"weight": "bolder",
"wrap": true,
"style": "heading"
}
],
"actions": [
{
"type": "Action.Submit",
"style": "positive",
"title": "Snooze",
"data": {
"x": "snooze"
}
},
{
"type": "Action.Submit",
"style": "destructive",
"title": "I'll be late",
"data": {
"x": "late"
}
}
]
}
Sample Code Language
No response
Sample Code
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the supplied Card JSON in the XAML renderer and compare the default, positive, and destructive action buttons. Trace the action styling entry point used for these three styles; done means positive and destructive actions have the same rounded corners as default actions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, xml
- Domain
- desktop, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100