microsoft / microsoft/AdaptiveCards

[Authoring] Missing AdditionalProperties Field in .net

Open
#8,785 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Schema Bug
Dominant language
C#
Stars
2k
Forks
595
Avg merge
1d 19h
Merged PRs (30d)
1

Description

Target Application

Missing AdditionalProperties fields in .net properties

Application Operating System

Windows

Schema Version

any

Problem Description

The C# AdaptiveCards Library is missing additionalProperties on at least BackGround Images under AdaptiveCard.BackgroundImages and AdaptiveCard.Refresh, AdaptiveCard.Authentication, and each property under AdaptiveCard.Authentication.Buttons.

It would be nice if you had a default class that everything derives from, that has properties like this, that should be on every property.

Expected Outcome

Every property should have additionalProperties

Actual Outcome

Many do not

Card JSON
Skipping as not relevant
Repro Steps

look at the file

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the C# AdaptiveCards library classes for AdaptiveCard.BackgroundImages, AdaptiveCard.Refresh, AdaptiveCard.Authentication, and Authentication.Buttons, then inspect how AdditionalProperties is represented elsewhere. Compare the named properties with existing patterns; done means the affected properties consistently expose AdditionalProperties and the relevant tests or schema checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend-api-design
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.