microsoft / microsoft/AdaptiveCards
[Schema] Schema properties point to the same object
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2k
- Forks
- 595
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 1
Description
Issue
This issue can be seen in the AC schema explorer because shared properties point to the same AC examples.
For instance, all inputs show the following example for errorMessage property because ChoiceSet build model was generated last.
Bug traced back to here:
https://github.com/microsoft/AdaptiveCards/blob/917f8c0c228848bca78ca01910df984c702a8bc9/source/nodejs/ac-typed-schema/src/markdown/build-model.ts#L65-L77
Elements that extend an abstract schema have the same object for the shared properties. Using errorMessage as an example, each time an input model is generated, the previous set of cardExamples is overridden.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in source/nodejs/ac-typed-schema/src/markdown/build-model.ts at lines 65-77 and trace how shared properties are generated for elements extending an abstract schema. Reproduce the issue in the AC schema explorer, using the errorMessage examples described in the report. Done means shared properties no longer point to the same examples across generated input models.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js, typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100