microsoft / microsoft/AdaptiveCards
[JS Renderer] isEnabled is not working for TextRun selectAction
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2k
- Forks
- 595
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 1
Description
Platform
- JavaScript
Sample
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.5/Tests/RichTextBlock.TextRun.SelectAction.IsEnabled.json
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.5/Tests/Action.IsEnabled.json
Issue
TextRun selectAction is not fully disabled when using isEnabled property. Clicking "here" in the image below launches another instance of the designer.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the two referenced samples, samples/v1.5/Tests/RichTextBlock.TextRun.SelectAction.IsEnabled.json and samples/v1.5/Tests/Action.IsEnabled.json, and reproduce the behavior in the JavaScript renderer. Trace how TextRun selectAction handles isEnabled compared with actions. Done means clicking the disabled “here” link no longer launches the designer, while enabled selectAction behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100