microsoft / microsoft/AdaptiveCards
[JS] Image height stretch does not fill column height
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2k
- Forks
- 595
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 1
Description
Platform
- JavaScript
Sample
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.1/Tests/ColumnSet.ImageSet.VerticalStretch.json
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.1/Tests/Image.Stretch.json
Issue
Image stretch is not consistent with the UWP renderer. Image space does not fill the entire column height.
UWP
JS
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the referenced samples, samples/v1.1/Tests/ColumnSet.ImageSet.VerticalStretch.json and samples/v1.1/Tests/Image.Stretch.json, and compare their JavaScript rendering with the UWP screenshots. Trace the JavaScript renderer's image stretch and column-height handling; done means the image space fills the column height consistently with UWP for these samples.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100