microsoft / microsoft/AdaptiveCards

[UI] Fractional lineHeight will cause scroll issues

Open
#8,283 2 comments 0 reactions 1 assignee View on GitHub

@jwoo-msft is already working on this.

Since Feb 14, 2023.

Dominant language
C#
Stars
2k
Forks
595
Avg merge
1d 19h
Merged PRs (30d)
1

Description

https://github.com/microsoft/AdaptiveCards/blob/f69bcb141a7d502efeee4931de745d1970a2b7bd/source/nodejs/adaptivecards/src/card-elements.ts#L1409

Since the 1.33 magic number factor will return a decimal into this._computedLineHeight, a safer alternative will be to wrap the multiplication operation in a Math.ceil('...') to ensure whole number pixel value.

The fractional (decimal) line height can cause issues with scrolling on containing parent element.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.