microsoft / microsoft/AdaptiveCards

[AdaptiveCards- Designer - Help]: 2 closed button as 'X and close' is set in the 'Help' dialog box and working of both are same.

Open
#8,174 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A11yMissing_HCLReviewed A11yPwD-AT A11yRT A11yUsable AdaptiveCards_Web Area-Accessibility Area-Renderers Bug GradeB HCL-AdaptiveCards-Web HCL-E+D MissingReviewedDeprecated Product-AC
Dominant language
C#
Stars
2k
Forks
595
Avg merge
1d 19h
Merged PRs (30d)
1

Description

Target Platforms

Other

SDK Version

1.5

Application Name

Adaptive Cards

Problem Description

Test Environment:
URL: https://adaptivecards.io/
OS Version: 22H2(OS Build 25247.1000)
Browser Version: Version 110.0.1543.0 (Official build) dev (64-bit)

Repro Steps:

  1. Open above URL with valid credential.
  2. Navigate to 'Designer' link and press enter key to activate it.
  3. Navigate to 'Help' button and press enter key.

Actual Result:
2 close buttons as 'X' and 'Close' are defined in the 'Help' dialog box, having the same functionality.

Expected Result:
Only one close button should be defined on the dialog box, and it should be descriptive so that user can easily understand about the element. Also, after activating the close button focus is lost.

User Experience:
It will impact all the user and mostly screen reader users, if the 2 close buttons are defined, which might be confusing.

"Have feedback to share on Bugs ? Please help fill Trusted Tester Bug Feedback (office.com) “.

Screenshots
Usable - 2 close button is defined
Card JSON
NA
Sample Code Language

No response

Sample Code

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue at adaptivecards.io by opening Designer, activating Help, and inspecting the dialog with keyboard navigation. Done means the Help dialog exposes one descriptive close control and focus remains usable after activation; the payload does not name an implementation file or test.

Written by the indexing model from the issue text.

Assessment

Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.