microsoft / microsoft/AdaptiveCards
[AdaptiveCards- Designer - Help]: 2 closed button as 'X and close' is set in the 'Help' dialog box and working of both are same.
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2k
- Forks
- 595
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 1
Description
Target Platforms
Other
SDK Version
1.5
Application Name
Adaptive Cards
Problem Description
Test Environment:
URL: https://adaptivecards.io/
OS Version: 22H2(OS Build 25247.1000)
Browser Version: Version 110.0.1543.0 (Official build) dev (64-bit)
Repro Steps:
- Open above URL with valid credential.
- Navigate to 'Designer' link and press enter key to activate it.
- Navigate to 'Help' button and press enter key.
Actual Result:
2 close buttons as 'X' and 'Close' are defined in the 'Help' dialog box, having the same functionality.
Expected Result:
Only one close button should be defined on the dialog box, and it should be descriptive so that user can easily understand about the element. Also, after activating the close button focus is lost.
User Experience:
It will impact all the user and mostly screen reader users, if the 2 close buttons are defined, which might be confusing.
"Have feedback to share on Bugs ? Please help fill Trusted Tester Bug Feedback (office.com) “.
Screenshots
Card JSON
NA
Sample Code Language
No response
Sample Code
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue at adaptivecards.io by opening Designer, activating Help, and inspecting the dialog with keyboard navigation. Done means the Help dialog exposes one descriptive close control and focus remains usable after activation; the payload does not name an implementation file or test.
Written by the indexing model from the issue text.
Assessment
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100