microsoft / microsoft/AdaptiveCards
[UWP Renderer] ImageRenderer PopulateImageFromUrlAsync isn't working
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2k
- Forks
- 595
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 1
Description
Platform
- UWP
Issue
Images are not rendering if you force the renderer to use the PopulateImageFromUrlAsync method.
Observation: We do not set the image source within this method
Example payload
{
"type": "AdaptiveCard",
"version": "0.5",
"body": [
{
"type": "Image",
"url": "https://pbs.twimg.com/profile_images/3647943215/d7f12830b3c17a5a9e4afcc370e3a37e_400x400.jpeg"
}
]
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in source/uwp/Renderer/lib/AdaptiveImageRenderer.cpp at PopulateImageFromUrlAsync, specifically the linked lines 426-462, and inspect how the image URL is handled. Use the provided Adaptive Card payload to reproduce the issue. Done means images render when this method is forced to handle the URL.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100