microsoft / microsoft/AdaptiveCards

[Parsing / Rendering] Forbidden Items

Open
#7,789 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
2k
Forks
595
Avg merge
1d 19h
Merged PRs (30d)
1

Description

Issue

We may want to re-think our parsing strategy for forbidden items.
Our current behavior of parsing forbidden item is dropping it and creates a warning.

We may want to re-think about dropping forbidden item in parsed card.

  1. round tripping not possible.
  2. our error handling is mostly done at render time. for example, we raise render warning if an element has invalid optional property. we raise render error if an element has invalid value for required property. Since we have skipped the forbidden element, we lose opportunity to alert the host app.

The down side of the change is that renderers will be burdened with recognizing forbidden items.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by locating the parser and renderer implementations and their forbidden-item warning paths; define whether forbidden items remain in the parsed card and how render-time warnings or errors should work. Done requires an agreed design plus coverage for round-tripping and host-app error reporting.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.